Expose RTLTextPluginStatus - #8864
Merged
Merged
Conversation
3 tasks
asheemmamoowala
suggested changes
Oct 12, 2019
asheemmamoowala
left a comment
asheemmamoowala
left a comment
Contributor
There was a problem hiding this comment.
The change to add and expose pluginStatus looks good. pluginRequested can probably removed too, and replaced with pluginStatus.
Contributor
Author
|
@asheemmamoowala I removed |
asheemmamoowala
approved these changes
Oct 14, 2019
arindam1993
suggested changes
Oct 14, 2019
arindam1993
left a comment
arindam1993
left a comment
Contributor
There was a problem hiding this comment.
plugin.isLoaded() should probably be moved to querying the enum as well.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch Checklist
fixes #7869
unavailable,loading,loadedorerror) through amapboxgl.getRTLTextStatusPluginmethodCHANGELOG
Expose
getRTLTextPluginStatusmethod