Handle Firefox SecurityError when opening window cache - #8780
Merged
Conversation
Catch the SecurityError thrown by Firefox 69+ when the worker tries to access the cache. Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
vakila
commented
Sep 20, 2019
vakila
left a comment
vakila
left a comment
Author
There was a problem hiding this comment.
👍 Thanks for the fixes @asheemmamoowala!
ryanhamley
approved these changes
Sep 20, 2019
asheemmamoowala
approved these changes
Sep 20, 2019
2 tasks
This was referenced Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch & warn on the SecurityError thrown by Firefox 69+ when the worker tries to access the cache.
cc @asheemmamoowala @mourner @arindam1993 @mapbox/studio @mapbox/map-design-team
Launch Checklist