Skip to content

add call to update and check before classList - #8757

Merged
asheemmamoowala merged 1 commit into
mapbox:masterfrom
zxwandrew:trackPointer-classList
Sep 17, 2019
Merged

add call to update and check before classList#8757
asheemmamoowala merged 1 commit into
mapbox:masterfrom
zxwandrew:trackPointer-classList

Conversation

@zxwandrew

@zxwandrew zxwandrew commented Sep 15, 2019

Copy link
Copy Markdown
Contributor
  • [ X ] briefly describe the changes in this PR
    • fixes Fix Popup.trackPointer Cannot read property 'classList' of undefined errors #8669
    • Add a call to _update when calling trackPointer. Checks to see if this._container exists. If not make sure tracking is set appropriately afterwards in _update. Also make sure the .mapboxgl-popup-track-pointer class is being properly applied in all scenarios. Added some unit test to ensure some new cases will now work.
  • [ X ] write tests for all new functionality
  • [ X ] manually test the debug page

@andrewharvey andrewharvey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you! I also tested this and found it worked well.

@asheemmamoowala asheemmamoowala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you and congratulations on your first contribution @zxwandrew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Popup.trackPointer Cannot read property 'classList' of undefined errors

3 participants