Skip to content

Fixes #8731 by adding tooltip to the geolocation control button. - #8735

Merged
mourner merged 2 commits into
mapbox:masterfrom
BAByrne:8731-control-button-tooltips
Sep 9, 2019
Merged

Fixes #8731 by adding tooltip to the geolocation control button.#8735
mourner merged 2 commits into
mapbox:masterfrom
BAByrne:8731-control-button-tooltips

Conversation

@BAByrne

@BAByrne BAByrne commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

Fixes issue #8734 (wrong issue # in commit msg) - Added a title attribute to geolocation control button.

  • briefly describe the changes in this PR
  • manually test the debug page

@ryanhamley

Copy link
Copy Markdown
Contributor

Thanks for the PR @BAByrne! It looks good. I'm just going to tag in a teammate for their thoughts on semantics.

@chloekraw This PR seems like a good idea but do you have any thoughts on what would be an appropriate tooltip text? Show my location is suggested here. Find my location might be a more accurate representation of the geolocation function. Also, in the navigation control, the buttons' title and aria-label are the same thing. I think we should probably follow that pattern here. The aria-label "Geolocate" seems a bit uninformative though so we should probably match it to whatever we decide on for a title.

@andrewharvey

Copy link
Copy Markdown
Collaborator

I added the "Geolocate" label back in #3492, I agree that "Geolocate", while it might be clear for web developers, it's probably not the clearest for the average user.

I think "Show my location" or "Find my location" are both fine. Sometimes the control will add a blue dot, sometimes it won't (depending on options) but I still think either are fine for both scenarios.

I agree we should keep title and aria-label in sync.

@chloekraw

Copy link
Copy Markdown
Contributor

@ryanhamley's suggestion of Find my location sounds good to me 👍

@BAByrne
BAByrne force-pushed the 8731-control-button-tooltips branch from 3b70b98 to bfddb33 Compare September 7, 2019 14:11
@mourner
mourner merged commit b8b3f7c into mapbox:master Sep 9, 2019
@BAByrne
BAByrne deleted the 8731-control-button-tooltips branch September 9, 2019 13:07
stepankuzmin pushed a commit to stepankuzmin/mapbox-gl-js that referenced this pull request Sep 9, 2019
mapbox#8735)

* Fixes mapbox#8731 by adding tooltip to the geolocation control button.

* Sets title and aria-label to "Find my location"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants