Fixes #8731 by adding tooltip to the geolocation control button. - #8735
Conversation
|
Thanks for the PR @BAByrne! It looks good. I'm just going to tag in a teammate for their thoughts on semantics. @chloekraw This PR seems like a good idea but do you have any thoughts on what would be an appropriate tooltip text? |
|
I added the "Geolocate" label back in #3492, I agree that "Geolocate", while it might be clear for web developers, it's probably not the clearest for the average user. I think "Show my location" or "Find my location" are both fine. Sometimes the control will add a blue dot, sometimes it won't (depending on options) but I still think either are fine for both scenarios. I agree we should keep title and aria-label in sync. |
|
@ryanhamley's suggestion of |
3b70b98 to
bfddb33
Compare
mapbox#8735) * Fixes mapbox#8731 by adding tooltip to the geolocation control button. * Sets title and aria-label to "Find my location"
Fixes issue #8734 (wrong issue # in commit msg) - Added a title attribute to geolocation control button.