Add originalEvent property to NavigationControl events - #8693
Merged
mourner merged 3 commits intoSep 9, 2019
Conversation
asheemmamoowala
approved these changes
Sep 6, 2019
asheemmamoowala
left a comment
asheemmamoowala
left a comment
Contributor
There was a problem hiding this comment.
@stepankuzmin Thanks for this fix. Looks good , but could you also add a note in the docs to signal that the MouseEvent can be a click when the zoom is triggered by a UI event.
Lines 216 to 219 in 506a3ef
stepankuzmin
pushed a commit
to stepankuzmin/mapbox-gl-js
that referenced
this pull request
Sep 9, 2019
Contributor
Author
@asheemmamoowala I've added a note for this |
Member
|
Also, could you please rebase on |
stepankuzmin
force-pushed
the
navigation_control_originalEvent
branch
from
September 9, 2019 16:13
1a6e9ea to
2772364
Compare
Contributor
Author
|
@mourner done! |
mourner
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
originalEventproperty to events initiated usingNavigationControl(zoom in, zoom out, reset bearing). Relates to #6405