Use MessageChannel instead of setTimeout to avoid processing delays - #8673
Merged
Merged
Conversation
mourner
approved these changes
Aug 22, 2019
mourner
requested changes
Aug 22, 2019
mourner
left a comment
mourner
left a comment
Member
There was a problem hiding this comment.
Now that the builds ran, looks like we need a MessageChannel fallback for Node.
also adds a fallback for environments that don't support MessageChannel
mourner
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8671.
It works around the
setTimeoutcaveats in IE (in my analysis, I found that setTimeout sometimes took more than 30 milliseconds just to execute the next call!) by switch to the universally supportedMessageChannelobjects. It's normally used to communicate between two different contexts, but you can also use it to "communicate" between the same context. It solves the performance regression reported in #8671 while maintaining the faster cancellation processing from #8633 by decoupling the messages sent from the counterpart from processing: it throttles thepostMessagecalls it receives from the sender to just one pendingpostMessage. This is essentially whatsetTimeout(..., 0)does too.