Fix icon/text collisionBox translation - #8659
Conversation
|
This change leads to one failing render test: debug/collision. As the rendering order may be changed for icon and text collisionBox, as they are now separated. Results are depicted as following: actual: diff: |
|
@zmiao It looks safe to update the fixture for that test. |
ansis
left a comment
ansis
left a comment
There was a problem hiding this comment.
This looks good to me! One small thing: there are some extra spaces added to some lines that didn't otherwise change. If possible it might be good to not include these changes.
asheemmamoowala
left a comment
asheemmamoowala
left a comment
There was a problem hiding this comment.
👍
@ansis the whitespace changes pass the linter, so maybe the eslint rules need to be updated to enforce a consistent convention here. That can be handled separately IMO
|
@ansis Whitespace is moved + changelog is added. Thanks for heads up. |
* init fix * fix lint error * fix indentation and wrong variable * add line placement translate render test * revert accidently added blank line * update comments * update one test fixture * Add changelog + remove whitespace
3 participants
Fix: js part of mapbox/mapbox-gl-native#13526
The root cause for it is that when rendering the symbols, the translate offset is only applied to icon/text, but the corresponding
collisionBoxis ignored. AlsocollisionBoxin currentSymbolBucketneeds to be split for icon and text symbol separately, in case they have different translate parameter.Launch Checklist