Add dragInertia options for custom drag panning - #8260
Closed
aMoniker wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR @aMoniker 😃 I think it looks good for the most part, but I think a cleaner api would be to allow setting these properties on |
This was referenced Oct 22, 2019
Contributor
Author
|
Nice work, thanks @arindam1993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds
dragInertiaoptions to the base map options.I don't know if this exposes too many options, and/or if there should be another option for setting
velocitydirectly. I also don't know if I'm following convention as this is my first PR to the codebase. Happy to change what's needed.I haven't written tests for this yet, but can once the idea & options format is considered acceptable. Likewise for public API documentation & benchmarks.
Fixes #4851
Launch Checklist