Eliminate tile lookups in drawing code - #7971
Closed
mourner wants to merge 1 commit into
Closed
Conversation
ansis
approved these changes
Mar 4, 2019
ansis
left a comment
ansis
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Have you checked that it works correctly with wrapped tiles? It looks like it should but it might be worth confirming.
Collaborator
|
Is this planned to be merged? This conflicts with #8380 and the longer the PR stays open, then later PRs will need to spend time resolving merge conflicts. |
Member
Author
|
Let's close this as stale, not a priority to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I pursuit this due to a glitch in DevTools that attributed a lot of time (10%) to
getTile(this later went away), but although in practice it doesn't change performance, it seems like it's making the code slightly simpler so maybe worth merging?Launch Checklist
write tests for all new functionalitydocument any changes to public APIs