Repository navigation
Espresso: Revert feature state reset - #7143
Closed
asheemmamoowala wants to merge 1 commit into
Closed
asheemmamoowala wants to merge 1 commit into
asheemmamoowala wants to merge 1 commit into
Conversation
…Data`, and document the reset in `Map#setFeatureState`"
Contributor
Author
|
Beaten to the 👊 by #7142 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7043 added a reset of a source's feature state every time it was reloaded. This was meant to target only
GeoJSONSource#setDatabut inadvertently also reset the feature data when a source went through a relayout. This was originally reported in [#62889(comment)(https://github.com//pull/6289#issuecomment-411186302) and a fix was put intomastervia #7129.For the espresso release, revert this behavior entirely. A more inclusive fix is being researched for
masteralong the lines of #6889.cc @jfirebaugh @mollymerp