Revert Data Join example until feature.id type issues are resolved - #6960
Merged
Conversation
Collaborator
ref #6019 (comment) but I wouldn't hold off the data join examples because of this. |
Contributor
Author
|
@andrewharvey we have discovered a few other ways that the ids are re-created or dropped. Overall the demo creates more trouble for developers with data outside of their control. It should be back soon as a few PR fixes land. A couple PRs related to this: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6580 updated the Data Join example to use the new
Map#setFeatureStateAPI. While the updated example shows the power of using the new API for data joins, it causes confusion with developers trying to use it in two ways:cc @ryanbaumann @samgehret