Skip to content

don't check cache when looking up a parent raster for fading - #2287

Closed
ansis wants to merge 1 commit into
masterfrom
fix-raster-parent-finding
Closed

ansis wants to merge 1 commit into
masterfrom
fix-raster-parent-finding

Conversation

@ansis

@ansis ansis commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

this used to check the cache for parent tiles and call addTile if it found one, and add unneeded tiles to pyramid._tiles.

👀 @lucaswoj

@lucaswoj

Copy link
Copy Markdown
Contributor

OOof. I see why this is unnecessary but this further adds to the spaghetti-code-ness of TilePyramid.

@lucaswoj

Copy link
Copy Markdown
Contributor

This is 🚢 as is. I'm going to ticket out some follow-up refactoring of TilePyramid

@lucaswoj lucaswoj mentioned this pull request Mar 18, 2016
@lucaswoj

Copy link
Copy Markdown
Contributor

@ansis Why is this marked as "do not merge"?

@ansis

ansis commented Mar 29, 2016

Copy link
Copy Markdown
Contributor Author

I'd like to look at a better way of doing this before merging. This isn't critical performance-wise

@lucaswoj

lucaswoj commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

Closing as stale.

@lucaswoj lucaswoj closed this Jun 8, 2016
@jfirebaugh
jfirebaugh deleted the fix-raster-parent-finding branch February 3, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants