pass GeoJSON in stringified form - #2222
Merged
Merged
Conversation
mourner
force-pushed
the
stringify-geojson
branch
from
March 4, 2016 17:26
c634d8c to
7a12ac2
Compare
Contributor
|
Given http://nolanlawson.com/2016/02/29/high-performance-web-worker-messages/ I wonder if we should just build |
Member
Author
|
@jfirebaugh I thought about that, but it's tricky because of transferables — you don't want to stringify an array buffer. |
Contributor
|
Yeah, it would have to be only if the |
Contributor
|
I'm 👍 on shipping this as-is and continuing to optimize per #1504 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reapplication of #2001 without changing the API, and serves as the middle ground for improving
setDataperformance as discussed in #1504.cc @lucaswoj @jfirebaugh @dcervelli