Conversation
|
This double check was added in #8904 specifically https://github.com/mapbox/mapbox-gl-js/pull/8904/files#diff-32491b8d513a9d3eb4a65cd5b5ded4b70be4f2cea814adbc54f437eaccf1af0cR367-R372 so I don't believe it's an oversight. Changing the |
karimnaaji
left a comment
karimnaaji
left a comment
There was a problem hiding this comment.
Good catch!
Changing the activeTexture may update state.atlasTextureIcon.
@ryanhamley there's no chance for that, it will only set the active texture binder in the webgl context, no side effect involved.
| state.atlasTexture.bind(state.atlasInterpolation, gl.CLAMP_TO_EDGE); | ||
| if (state.atlasTextureIcon) { | ||
| context.activeTexture.set(gl.TEXTURE1); | ||
| if (state.atlasTextureIcon) { |
There was a problem hiding this comment.
Was this meant to check atlasInterpolationIcon maybe?
|
Jannik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@JannikGM If you'd still like to contribute this, you will need to sign our new Contributor License Agreement. I'm going to close this as stale, but if you sign the CLA, we can re-open it. |
3 participants
This removes a redundant check in
drawLayerSymbols.We already check for
state.atlasTextureIconin line 367, and (unless I'm missing something) it shouldn't have changed by line 369.(It would be nice if you can tag this PR for hacktoberfest inclusion as described in https://hacktoberfest.digitalocean.com/details#rules - feel free to ignore this last bit if you don't want this)