Skip to content

Implement SymbolStyleLayer#queryRadius() (queryRenderedFeatures fix) #6298

Description

@ChrisLoer

The current implementation just returns "0":

queryRadius(): number {
return 0;
}

This means that symbols that "bleed over" into the tile next to them won't show up in a queryRenderedFeatures query that intersects their geometry but doesn't intersect their original tile. This wasn't much of an issue before #5150 because the symbol would generally be included in both tile's collision indices.

Once #6036 goes in, we'll have an upper bound on the amount of "pitch scaling" that can apply to text. We can implement queryRadius here by going through all the symbols in the bucket and keeping the max dimensions.

/cc @ansis

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions