Repository navigation
Avoid retaining GeoJSONSource data on main thread #3220
Description
Activity
One thing we'll need to resolve is how
setStyle's diff should handle GeoJSON sources. As of now, we're doing a deep equality test, which is probably not what we want (see also #4006 (comment)).
GeoJSONSourceretains any data set viaMap#addSource(...)orGeoJSONSource#setDatain a_datamember. This data is included in theserialized representation of the source, but as far as I can tell, that's unnecessary: the only thing that serialized sources are used for is style validation, which does not care about GeoJSON data.Because the data is also passed to the worker, we are effectively doubling the memory requirements of GeoJSON sources. We could avoid creating a member variable, or set it to
nullafter sending the data to the worker, which would eliminate this overhead.