Telemetry events are dropped when network is disconnected

EDIT: I removed the bug label. This is potentially a feature, considering it hasn't been implemented?

Configuration

SDK Version All
Android OS Version All
Device model(s): All
App: All

Steps to Reproduce

launch app with telemetry
put device in airplane mode
events are dropped

Expected
Don't drop network is disconnected

Logging
Looks like the queue is flushed here, which removes all the events

mapbox-events-android/libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java

Lines 278 to 294 in 19ca456

    
           private synchronized void flushEnqueuedEvents() { 
        
             final List<Event> currentEvents = queue.flush(); 
        
             if (currentEvents.isEmpty()) { 
        
               return; 
        
             } 
        
             executeRunnable(new Runnable() { 
        
               @Override 
        
               public void run() { 
        
                 try { 
        
                   sendEvents(currentEvents, false); 
        
                 } catch (Throwable throwable) { 
        
                   // TODO: log silent crash 
        
                   Log.e(LOG_TAG, throwable.toString()); 
        
                 } 
        
               } 
        
             }); 
        
           }

When the connection is unavailable, these events are dropped

mapbox-events-android/libtelemetry/src/full/java/com/mapbox/android/telemetry/MapboxTelemetry.java

Lines 310 to 314 in 19ca456

    
           private synchronized void sendEvents(List<Event> events, boolean serializeNulls) { 
        
             if (isNetworkConnected() && checkRequiredParameters(sAccessToken.get(), userAgent)) { 
        
               telemetryClient.sendEvents(events, httpCallback, serializeNulls); 
        
             } 
        
           }

Navigation Menu

Repository navigation

Telemetry events are dropped when network is disconnected #481

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	private synchronized void flushEnqueuedEvents() {
	final List<Event> currentEvents = queue.flush();
	if (currentEvents.isEmpty()) {
	return;
	}
	executeRunnable(new Runnable() {
	@Override
	public void run() {
	try {
	sendEvents(currentEvents, false);
	} catch (Throwable throwable) {
	// TODO: log silent crash
	Log.e(LOG_TAG, throwable.toString());
	}
	}
	});
	}

	private synchronized void sendEvents(List<Event> events, boolean serializeNulls) {
	if (isNetworkConnected() && checkRequiredParameters(sAccessToken.get(), userAgent)) {
	telemetryClient.sendEvents(events, httpCallback, serializeNulls);
	}
	}

Telemetry events are dropped when network is disconnected #481

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions