Fetch full user details to populate author.WebsiteURL#24
Open
zonorti wants to merge 2 commits into
Open
Conversation
Signed-off-by: Zon <zon@aignostics.com>
Signed-off-by: Zon <zon@aignostics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I found the tool I was really excited about having users automatically replaced with their Github handles.
Unfortunately it seems like it no longer works due to Gitlab API returning less data and skipping WerbsiteURL property.
This PR adds fetching full user info instead of minimal one that
ListUsersprovides.After adding this fix I get
githubAuthorNameset correctly.Additional info:
According to documentation more fields are returned with an administrator runs this command. So getting admin permissions is a workaround.
Update:
By checking for CreatedAt field we can see if we got full response or need to fetch more details. This saves and API call if we are already GitLab Admin.