Skip to content

fix: linter pass that checks nursery rule namespaces against exis - #3208

Open
Mr-Neutr0n wants to merge 3 commits into
mandiant:masterfrom
Mr-Neutr0n:agent/issue-3112-linter-pass-that-checks
Open

Mr-Neutr0n wants to merge 3 commits into
mandiant:masterfrom
Mr-Neutr0n:agent/issue-3112-linter-pass-that-checks

Conversation

@Mr-Neutr0n

Copy link
Copy Markdown

Fixes #3112

Added a nursery-namespace lint warning that flags close spellings of existing rules directories while allowing genuinely new namespaces.

Local tests pass.


This change was prepared with AI assistance under human direction and review.

…ainst exis

Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

…espace linter pass to s

Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
@Mr-Neutr0n

Copy link
Copy Markdown
Author

Pushed a fix for the failing CI. Added CHANGELOG entry for nursery namespace linter pass to satisfy check_changelog.

@github-actions
github-actions Bot dismissed their stale review October 27, 2026 11:59

CHANGELOG updated or no update needed, thanks! 😄

…linter-pass-that-checks

# Conflicts:
#	CHANGELOG.md
#	tests/test_scripts.py
@Mr-Neutr0n

Mr-Neutr0n commented Nov 4, 2026 •

Copy link
Copy Markdown
Author

Merged current master (fb4f38a4), clearing the conflict.

Both conflicts were additive, not competing:

  • CHANGELOG.md: master had added two unrelated entries (idalib fixture compatibility, setup-uv cache key) at the same point. All three lines kept.
  • tests/test_scripts.py: master added test_feature_regex_without_literal where this branch adds test_nursery_namespace_typo_compares_against_existing_directories. Taking either side wholesale would have dropped a test, and the naive interleave spliced the two function bodies together, so I rebuilt the file from master and appended this branch's test, which is self-contained.

Verified: pytest tests/test_scripts.py -k "nursery or feature_regex" — 3 passed, covering both the new pass and master's.

Correction on 2026-11-10: the full test-file run reported 16 failures, but the attempted comparison against unmodified master did not complete because the checkout was still in a conflicted merge. My earlier claim that those failures were reproduced on clean master was not established. Only the three targeted passes above are verified for that update. The rules-linter failure was separately reproduced on upstream, but that does not establish a baseline for the full pytest file.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter pass that checks nursery rule namespaces against existing directory structure

1 participant