geolocation: add geoprobe identity to signed TWAMP replies, make verify interval configurable#3168
Merged
geolocation: add geoprobe identity to signed TWAMP replies, make verify interval configurable#3168
Conversation
…ratble and defaults to 29s instead of 55s. Default geprobe-target-sender interval is 30s.
Contributor
Author
|
Skip-changelog is because this is updates to something already in the changelog. |
nikw9944
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3166
Summary of Changes
GeoprobePubkeyfield to signed TWAMP reply packets so targets can distinguish which physical probe responded, even when multiple probes share the same signing authorityReflectorPubkey→AuthorityPubkeyfor clarity (reply now carries both the authority and geoprobe identities)VerifyIntervalglobal with a per-reflector constructor argument, exposed as--verify-intervalCLI flag on geoprobe-agent (default 29s)geoprobe-target-senderfrom 60s to 30s to fit within the verify windowDiff Breakdown
Most change is in tests and packet structure; core logic is a small net addition.
Key files (click to expand)
tools/twamp/pkg/signed/packet.go— add GeoprobePubkey field, rename ReflectorPubkey → AuthorityPubkey, update reply size (204→236 bytes)tools/twamp/pkg/signed/reflector_linux.go— store verifyInterval and geoprobePubkey as struct fields, use per-instance intervaltools/twamp/pkg/signed/reflector.go— remove global VerifyInterval var, add verifyInterval param to constructorcontrolplane/telemetry/cmd/geoprobe-agent/main.go— add--verify-intervalflag (default 29s), pass geoprobePubkey + interval to reflectorcontrolplane/telemetry/cmd/geoprobe-target-sender/main.go— lower default interval to 30s, adapt to renamed reply fieldsrfcs/rfc16-geolocation-verification.md— update reply packet layout to reflect new GeoprobePubkey fieldTesting Verification
tools/twamp/pkg/signedtests pass (packet round-trip, byte layout, rate-limit, concurrent clients, signature verification)geoprobe-target-senderunit tests pass