smartcontract: preserve case for location codes#3080
Merged
martinsander00 merged 3 commits intomainfrom Mar 5, 2026
Merged
Conversation
martinsander00
force-pushed
the
ms/2717
branch
from
d1fe79a to
2d0c0e9
Compare
juan-malbeclabs
requested changes
Mar 5, 2026
Contributor
juan-malbeclabs
left a comment
juan-malbeclabs
left a comment
There was a problem hiding this comment.
Please add a unit test to verify that device searches are case-insensitive and that the SDK at least attempts to prevent duplicate entries.
Use uppercase codes in existing tests to verify that locations, exchanges, and contributors preserve case, while devices and links are lowercased.
juan-malbeclabs
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2717
Summary
validate_account_codeunintentionally forcing lowercase on all entity types, including locations whose codes have historically been uppercase in mainnet-betavalidate_account_codeto its original case-preserving behavior (pre-refactor: enforce lowercase for dzd and link naming #2383) and applymake_ascii_lowercase()inline at device and link call sites onlyTesting Verification
validate_account_codepreserves casedoublezero-program-common,doublezero-serviceability,doublezero_sdk, anddoublezero_clipass