Repository navigation
Classify Safe Updates writes as destructive - #13
Draft
dennisdornon wants to merge 1 commit into
Draft
dennisdornon wants to merge 1 commit into
dennisdornon wants to merge 1 commit into
Conversation
The Safe Updates abilities that start, continue or cancel a run, retest a site or mark a failed check as expected now match the destructive name patterns, so each needs --dry-run and then --confirm whatever the Dashboard's annotations say. rollback-safe-update-v1 already matched rollback-*. The Dashboard requires a preview or confirm for retest and resolve as well, and the CLI only sends confirm on the destructive path, so leaving those two out would make them impossible to run. The run and list reads keep their classification, and docs/safety.md describes the Safe Updates behavior.
dennisdornon
marked this pull request as ready for review
November 20, 2026 13:32
dennisdornon
marked this pull request as draft
November 20, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Safe Updates abilities that start, continue or cancel a run, retest a site, or mark a failed check as expected now match the destructive name patterns. Each one needs
--dry-runand then--confirm, whatever the Dashboard's annotations say.rollback-safe-update-v1already matchedrollback-*. The run and list reads keep their classification.docs/safety.mddescribes the Safe Updates behavior, and tests cover each ability name.