can libaums support multiple devices connect simultaneously

Hi, now I'm need to handle multiple devices at the same time, but I don't known if this library support it.

Hey there,

I have never really tried it, but it should work. Just try it and tell me if you have any problems.

Hi, I've tried it many times, I used a usb hub to connect to
the connected devices, the other one use to show the content of the specific deivce, when I clicked a specific device, I will refresh the content listview,
content listview, I can't got the subdirectory of it and I got an error log as blow:
java.io.IOException: Could not write to device, result == -1
at com.github.mjdev.libaums.usb.JellyBeanMr2Communication.bulkOutTransfer(JellyBeanMr2Communication.java:42)
at com.github.mjdev.libaums.driver.scsi.ScsiBlockDevice.transferCommand(ScsiBlockDevice.java:143)
at com.github.mjdev.libaums.driver.scsi.ScsiBlockDevice.read(ScsiBlockDevice.java:209)
at com.github.mjdev.libaums.partition.Partition.read(Partition.java:142)
at com.github.mjdev.libaums.fs.fat32.FAT.getChain(FAT.java:134)
at com.github.mjdev.libaums.fs.fat32.ClusterChain.(ClusterChain.java:64)
at com.github.mjdev.libaums.fs.fat32.FatDirectory.init(FatDirectory.java:156)
at com.github.mjdev.libaums.fs.fat32.FatDirectory.listFiles(FatDirectory.java:485)
at star.usbdevicescontroller.usbmode.UsbFileListAdapter.refresh(UsbFileListAdapter.java:80)
at star.usbdevicescontroller.usbmode.UsbFileListAdapter.(UsbFileListAdapter.java:60)
at star.usbdevicescontroller.usbmode.UsbActivity$2.onItemClick(UsbActivity.java:255)
at android.widget.AdapterView.performItemClick(AdapterView.java:310)
at android.widget.AbsListView.performItemClick(AbsListView.java:1145)
at android.widget.AbsListView$PerformClick.run(AbsListView.java:3066)
at android.widget.AbsListView$3.run(AbsListView.java:3903)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:742)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:632)
could not release interface!
could not release interface!
your help, thanks advance.
understand me :) )

And here are some relative code snippets:

private void discoverDevice() {
    UsbManager usbManager = (UsbManager) getSystemService(Context.USB_SERVICE);
    UsbMassStorageDevice[] devices = UsbMassStorageDevice.getMassStorageDevices(this);

    if (devices.length == 0) {
        ActionBar actionBar = getSupportActionBar();
        if(actionBar != null) {
            actionBar.setTitle(R.string.usb_no_devices);
        }
        listView.setAdapter(null);
        return;
    }

    // the type of storageDevices is List<UsbMassStorageDevice>
    // add all founded usb device to the recycler view
    for(int i=0; i<devices.length; i++) {
        storageDevices.add(devices[i]);
    }
    UsbDevice usbDevice = getIntent().getParcelableExtra(UsbManager.EXTRA_DEVICE);

    if (usbDevice != null && usbManager.hasPermission(usbDevice)) {
        setupDevice();
    } else {
        for(int i=0; i< storageDevices.size(); i++) {
            PendingIntent permissionIntent = PendingIntent.getBroadcast(this, 0, new Intent(ACTION_USB_PERMISSION), 0);
            usbManager.requestPermission(storageDevices.get(i).getUsbDevice(), permissionIntent);
        }
    }
}

private void setupDevice() {
    try {
        long sTime = System.currentTimeMillis();
        for(int i=0; i<storageDevices.size(); i++) {
            storageDevices.get(i).init();
        }

        long eTime = System.currentTimeMillis();
        textViewSpeed.setText("Init all devices, devices count = " + storageDevices.size() + ", use time " + (eTime - sTime) + "ms");

        UsbMassStorageDevice curUsbDevice = storageDevices.get(0);
        customAdapter.setStorageDevices(storageDevices);

        // we always use the first partition of the usbMassStorageDevice0
        FileSystem fileSystem = curUsbDevice.getPartitions().get(0).getFileSystem();

        UsbFile root = fileSystem.getRootDirectory();
        ActionBar actionBar = getSupportActionBar();
        if(actionBar != null) {
            actionBar.setTitle(fileSystem.getVolumeLabel());
        }

        listView.setAdapter(usbFileListAdapter = new UsbFileListAdapter(this, root));
    } catch (IOException e) {
        Log.e(TAG, "error setting up usbMassStorageDevice", e);
    }

}

    onItemClickListener = new AdapterView.OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long rowId) {
            UsbFile entry = usbFileListAdapter.getItem(position);
            try {
            if (entry.isDirectory()) {

                dirs.push(usbFileListAdapter.getCurrentDir());

                // TODO multiple devices cause IOException at here
                listView.setAdapter(usbFileListAdapter = new UsbFileListAdapter(UsbActivity.this, entry)); 
                
            } else {

                if (ContextCompat.checkSelfPermission(UsbActivity.this, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {

                    if (ActivityCompat.shouldShowRequestPermissionRationale(UsbActivity.this, Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
                        Toast.makeText(UsbActivity.this, R.string.request_write_storage_perm, Toast.LENGTH_LONG).show();
                    } else {
                        ActivityCompat.requestPermissions(UsbActivity.this, new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE}, REQUEST_EXT_STORAGE_WRITE_PERM);
                    }
                    return;
                }

                CopyTaskParam copyTaskParam = new CopyTaskParam();
                copyTaskParam.from = entry;

                // ------ TODO set the file path at here
                File file = new File(Environment.getExternalStorageDirectory().getAbsolutePath() + "/usbfileman/cache");

                boolean ret = file.mkdirs();
                int index = entry.getName().lastIndexOf(".") > 0 ? entry.getName().lastIndexOf(".") : entry.getName().length();
                String prefix = entry.getName().substring(0, index);
                String ext = entry.getName().substring(index);
                // prefix must be at least 3 characters
                if(prefix.length() < 3) {
                    prefix += "pad";
                }
                    copyTaskParam.to = File.createTempFile(prefix, ext, file);
                    new CopyTask().execute(copyTaskParam);
            }
            }
            catch (IOException e) {
                Log.e(TAG, "error staring to copy!", e);
            }
        }
    };

Hi, I found that when connect multiple devices, the JellyBeanMr2Communication Ojbect refrence to the wrong UsbDeviceConnection Object, but I can't find the specific position of the bug.

Hey there. Are you sure that is the case? This line creates the connection: https://github.com/magnusja/libaums/blob/develop/libaums/src/main/java/com/github/mjdev/libaums/UsbMassStorageDevice.java#L213

So I assume you are using a USB Hub, so maybe there is a shared device connection involved, because of that. I never tried that to be honest. But the error you have is unfortunately not very specific in what exactly failed.

What you maybe can do is change from the synchronous data transfer to the USB request mode like so (before you are initializing any devices):
UsbCommunicationFactory.setUnderlyingUsbCommunication(UnderlyingUsbCommunication.USB_REQUEST_ASYNC);

Are you closing the devices when you change to another one? If not, try that maybe.

I am currently on a road trip so I cannot say when I will be able to test that myself.

I can't closing any devices, because I need to copy data from all the devices at the same time.

And I've tried UsbCommunicationFactory.setUnderlyingUsbCommunication(UnderlyingUsbCommunication.USB_REQUEST_ASYNC);
but it didn't work

I tried to modify the motheds of the UsbFile interface like this
UsbFile[] listFiles(UsbDeviceConnection deviceConnection) throws IOException;
and modity the relative implements, then it worked, but I don't think this is a good way.

I don't think I understand, can you show some code?

To be honest, I don't really sure if I have a full understand of your idea, maybe I've wrong, so I need you guide. I've tried to make some debug in you project, and upload it as a temp project to github, soon I'll delete it. you can download it from
https://github.com/StormLion/tproject

Thanks, I downloaded it and will have a look as soon as I am home.

If you get multiple device supporting done, please post a little code snippet on how to achieve it. Thanks.

Fixed with #242

I'll add this one to the list of things I'll want to test on Qemu. This should also cover the case of devices with multiple USB ports without an external hub, for example on Android x86.

Navigation Menu

Repository navigation

can libaums support multiple devices connect simultaneously #71

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

can libaums support multiple devices connect simultaneously #71

Description

Activity

magnusja commented on Mar 15, 2017

StormLion commented on Mar 16, 2017

StormLion commented on Mar 16, 2017

StormLion commented on Mar 17, 2017

magnusja commented on Mar 17, 2017

StormLion commented on Mar 20, 2017

StormLion commented on Mar 20, 2017

StormLion commented on Mar 20, 2017

magnusja commented on Mar 20, 2017

StormLion commented on Mar 21, 2017

magnusja commented on Mar 21, 2017

blood-mist commented on Mar 29, 2017

magnusja commented on May 13, 2020

depau commented on May 13, 2020

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions