feat: add data-testid attributes to key UI elements for automated testing - #1741
Open
aditya226-sharma wants to merge 1 commit into
Open
feat: add data-testid attributes to key UI elements for automated testing#1741aditya226-sharma wants to merge 1 commit into
aditya226-sharma wants to merge 1 commit into
Conversation
…ting Add data-testid attributes to the following elements: - file-upload-zone: File upload drag-drop area - export-button: Export video button - export-progress: Export progress bar - download-button: Download result link - reset-button: Reset/New video button - quality-slider: Quality CRF range slider - speed-slider: Speed range slider No visual or functional changes. Prepares codebase for Playwright/RTL tests. Closes magic-peach#56
|
@aditya226-sharma is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @aditya226-sharmaBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @aditya226-sharma!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Author
|
@magic-peach Gentle ping — adds data-testid attributes for testing. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
data-testidattributes to key UI elements across the component tree to prepare the codebase for automated testing with Playwright or React Testing Library.Changes
file-upload-zoneFileUpload.tsxexport-buttonVideoEditor.tsxexport-progressExportOverlay.tsxdownload-buttonDownloadResult.tsxreset-buttonDownloadResult.tsxquality-sliderExportSettings.tsxspeed-sliderAudioSpeedControl.tsxAcceptance Criteria
data-testidattributesCloses #56
GSSoC'26 contribution