This repository was archived by the owner on Dec 2, 2025. It is now read-only.
enable aarch64 support for lz4-java - #86
Merged
Merged
Conversation
This patch enables the lz4-java support for aarch64 architecture it would 1) enables the 64bit access for lz4 native lib embedded in lz4-java 2) adds the JNI native objects which has been build Signed-off-by: Rocky Zhang <rocky.zhang@linaro.org>
|
Is this patch ok to be merged for support for AArch64? |
|
Hi @jpountz , Could you please give some comments for this? BRs |
Contributor
|
@Cyan4973 Is there any obstacle to merge this PR? I've verified it on AArch64 |
Member
|
I don't have any reason to think there is any problem, but I shouldn't be the one to judge it. |
Contributor
|
@Cyan4973, Really thanks for your quick response. I'm looking forward to getting any feedback for this patch from the new lz4-java maintainer. |
Member
|
Thanks much for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables the lz4-java support for aarch64 architecture it would
Signed-off-by: Rocky Zhang rocky.zhang@linaro.org