chore(bench): update bench deps, add teenytest, and update bench runner for node 12+#165
Open
davemo wants to merge 5 commits into
Open
chore(bench): update bench deps, add teenytest, and update bench runner for node 12+#165davemo wants to merge 5 commits into
davemo wants to merge 5 commits into
Conversation
- node 12 and up start throwing ERR_PACKAGE_PATH_NOT_EXPORTED if the module includes an exports key that does not explicitly expose the imported path when accessed with require.resolve - https://nodejs.org/docs/latest-v12.x/api/all.html#errors_err_package_path_not_exported - this fix removes the require.resolve resolution in order to access the truly private executables for modules that dont all expose their internals in this way
benmccann
approved these changes
May 10, 2023
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
I can confirm that bench/index.js doesn't fun for me on Node 18, but does run with the changes included here, so whether or not you want to add teenytest, the changes to bench/index.js seem like a good idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to try out the benchmarks but hit an error as it seemed there was an expected behaviour using
require.resolvein nodev10that no longer works inv12+.The benchmark, when run with
node index.jswas throwing this error for bothuvuandtape:This PR fixes that error by using absolute paths to
./node_modules, so that you don't have to rely on upstream test frameworks to expose their internals withinpackage.exports, and updates the benchmark test framework dependencies, along with adding a benchmark for testdouble/teenytest.Updated numbers I got running on Node 16 on a 2013 MBP w/ 16gb RAM: