Repository navigation
[rtl] Clear branch predictor skid buffer on PC redirect - #2521
Open
zxz2004626 wants to merge 1 commit into
Open
zxz2004626 wants to merge 1 commit into
zxz2004626 wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document. By submitting this pull request comment, I am hereby confirming my acceptance of the terms of the CLA Document and my agreement to be legally bound by its terms. |
SamuelRiedel
self-requested a review
October 7, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix #2520 .
The IF-stage skid buffer introduced with BranchPredictor=1 has no invalidation term for pipeline redirects: an occupied skid survives the controller's FLUSH state, so a predicted-taken branch stranded in the skid is executed as the first post-trap instruction with the raised privilege level. From U-mode this turns any synchronous trap into a U->M privilege escalation.
Invalidate the skid whenever
pc_set_iis asserted, mirroring the~pc_set_iterm that already guards fill viainstr_skid_en.