Repository navigation
[dv] Use the TweakInfection name in the icache TB - #2510
Merged
Merged
Conversation
h-filali
reviewed
Sep 24, 2026
h-filali
left a comment
h-filali
left a comment
There was a problem hiding this comment.
Thanks for your PR. Would you mind also aligning the spaces?
Commit 556dff1 added the TweakInfection parameter to ibex_icache and passed it from the icache testbench as .ICacheTweakInfection, which is the name used one level up in ibex_if_stage. ibex_icache has no parameter of that name, so the icache UVM testbench no longer elaborates (VCS stops with Error-[AOUP]). Pass the TB's ICacheTweakInfection parameter to TweakInfection, as ibex_if_stage does, and align the parameter list the same way. Signed-off-by: Kulan Palanichamy <kulan.palanichamy@opentitan.org>
kulan-pal
force-pushed
the
dv/icache-tb-param
branch
from
September 24, 2026 23:17
b41069a to
f18f3b6
Compare
Contributor
Author
|
Done: the parameter list is aligned like the ibex_icache instance in ibex_if_stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dv/uvm/icache/dv/tb/tb.svpasses itsICacheTweakInfectionparameter toibex_icacheas.ICacheTweakInfection, butibex_icachecalls the parameterTweakInfection. With dvsim's VCS options(
-error=AOUP) the icache testbench does not elaborate. Private CI on #2497 reports 9/9 passes with Xcelium21.09-s006, seed 123; its elaboration output is not in the log. The mismatch came in with 556dff1 ("[icache/rtl]
Tweak infection");
ibex_if_stagegot it right (.TweakInfection (ICacheTweakInfection)).This change connects the tb parameter to
TweakInfection. The tb parameter keeps its name and its default of 1.ibex_icache_smokeon mastere1a6be2c, seed 1Error-[AOUP]at elaborationibex_icache_smokeon this branch, seed 1ibex_icache_ecc,ibex_icache_invalidationon this branch, seed 1ibex_icache_caching,ibex_icache_eccon this branch, seed 1,--covIndependent fix on
e1a6be2c, no dependencies. Run with VCS U-2023.03-SP2 and the default TB parameters(
ICacheECC = 1,ICacheTweakInfection = 1).Merged coverage records data ECC errors on lookup hits and tag ECC errors on lookups; both scoreboards pass. Only
the ECC sequence enables error injection. These passes do not validate
ecc_error_o: the existingibex_icache_ram_if.svassertions passrst_nas an active-high reset, so they are disabled out of reset.AI disclosure (CLA §9): written with help from Claude Code and reviewed with OpenAI Codex; I have reviewed and understood every change and take full responsibility for it.