Repository navigation
[nix] Fix python in nix - #2507
Merged
Merged
Conversation
elliotb-lowrisc
approved these changes
Sep 18, 2026
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure how, but this seems to restore my ability to build the eda_shell
hcallahan-lowrisc
approved these changes
Sep 21, 2026
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @SamuelRiedel, LGTM! One small suggestion to simplify slightly.
Comment on lines
+27
to
+35
| (inputs.uv2nix_hammer_overrides.overrides pkgs) | ||
| uvLockedOverlay | ||
| (final: prev: { | ||
| # PyYAML 6.0 uses setuptools as its build backend without declaring | ||
| # it in its package metadata. | ||
| pyyaml = prev.pyyaml.overrideAttrs (old: { | ||
| nativeBuildInputs = (old.nativeBuildInputs or [ ]) ++ [ final.setuptools ]; | ||
| }); | ||
| }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| (inputs.uv2nix_hammer_overrides.overrides pkgs) | |
| uvLockedOverlay | |
| (final: prev: { | |
| # PyYAML 6.0 uses setuptools as its build backend without declaring | |
| # it in its package metadata. | |
| pyyaml = prev.pyyaml.overrideAttrs (old: { | |
| nativeBuildInputs = (old.nativeBuildInputs or [ ]) ++ [ final.setuptools ]; | |
| }); | |
| }) | |
| uvLockedOverlay | |
| (inputs.uv2nix_hammer_overrides.overrides pkgs) | |
Collaborator
There was a problem hiding this comment.
You can actually just do this (I got this the wrong way around when I originally wrote this code, but the uv2nix_hammer provides all the fixes we need, including the pyyaml one).
Contributor
Author
There was a problem hiding this comment.
Thanks Harry, I implemented your feedback.
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
hcallahan-lowrisc
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.