Skip to content

docs: fix hasMany diagram L&F#1577

Merged
dhmlau merged 1 commit into
masterfrom
fix-diagram
Aug 2, 2018
Merged

docs: fix hasMany diagram L&F#1577
dhmlau merged 1 commit into
masterfrom
fix-diagram

Conversation

@dhmlau

@dhmlau dhmlau commented Jul 30, 2018

Copy link
Copy Markdown
Member

Change the L&F of the hasMany diagram to something similar to the todo overview digram.

Fixes #1532

@marioestradarosa

Copy link
Copy Markdown
Contributor

How about this one? . I think the customerId on Order table should be number.

er_diagram_lb4

@dhmlau

dhmlau commented Jul 31, 2018

Copy link
Copy Markdown
Member Author

@marioestradarosa , thanks for catching the error. I like your diagram!
May I know what software do you use to create the diagram? Cannot find the arrow style in PowerPoint.

We're trying to use these color palettes for the LB4 documentation diagrams. If you could modify your diagram using those colors (I think only the green is off?), please feel free to submit another PR, I'm happy to abandon this one.

@marioestradarosa

Copy link
Copy Markdown
Contributor

@dhmlau I used Keynote and the many arrow is coming from one of the connectors (actually you have to mold it a little bit). I am color blind, so I think I never saw the green line :-) . don't worry about the PR you can use the diagram on this PR. If you want me to send you the KeyNote file, I will send it to you.

lb4_er_cust_order 001

@b-admike

Copy link
Copy Markdown
Contributor

Thank you for fixing this @dhmlau @marioestradarosa, the new one is looking great 👍

@dhmlau

dhmlau commented Jul 31, 2018

Copy link
Copy Markdown
Member Author

Thanks @marioestradarosa. I've updated with your diagram.

@bajtos bajtos mentioned this pull request Aug 1, 2018
31 tasks
@virkt25 virkt25 added this to the August Milestone milestone Aug 1, 2018
@dhmlau dhmlau merged commit 8db804f into master Aug 2, 2018
@dhmlau dhmlau deleted the fix-diagram branch August 2, 2018 01:48
@dhmlau

dhmlau commented Aug 2, 2018

Copy link
Copy Markdown
Member Author

Thanks @marioestradarosa. The PR has merged. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants