Improve structure of the code and update to python3#80
Closed
gutjuri wants to merge 13 commits intologpai:masterfrom
Closed
Improve structure of the code and update to python3#80gutjuri wants to merge 13 commits intologpai:masterfrom
gutjuri wants to merge 13 commits intologpai:masterfrom
Conversation
xpai
pushed a commit
that referenced
this pull request
Sep 5, 2023
xpai
pushed a commit
that referenced
this pull request
Sep 5, 2023
xpai
pushed a commit
that referenced
this pull request
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the structure of the code.
We now have less code duplication and all configuration/parameters are in benchmark/LogSettings.py. I think this has the advantage that the project is now easier to extend with other data sets or log parsers.
I also updated the code, so now it is runnable with python3.
If you request any changes, please let me know:)