[TOSA] Add TosaLayerwiseConstantFoldPass and TosaReduceTransposes passes#4165
Merged
Conversation
Add the following passes to TorchBackendToTosaBackendPipeline: - TosaLayerwiseConstantFoldPass: fold full-layer operations on TOSA consts - TosaReduceTransposes: remove unnecessary TOSA transposes to reduce data movements Signed-off-by: Justin Ngo <justin.ngo@arm.com> Change-Id: I44636a7392a571e57c2c3a2c0316835d2d2ca938
sahas3
reviewed
Apr 25, 2025
sahas3
left a comment
sahas3
left a comment
Member
There was a problem hiding this comment.
LGTM, except for the timeout comment. I am not sure if increasing the timeout for all conversion paths is acceptable.
sahas3
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following passes to TorchBackendToTosaBackendPipeline: