Repository navigation
[AVR] Implement selection of 'ISD::RETURNADDR' and 'ISD::FRAMEADDR' - #222909
Merged
Merged
Conversation
benshi001
force-pushed
the
avr-fix-issue-179991
branch
2 times, most recently
from
September 11, 2026 10:19
ceab335 to
ebf21bc
Compare
Contributor
|
🔍 |
Patryk27
requested changes
Sep 17, 2026
Patryk27
left a comment
Patryk27
left a comment
Contributor
There was a problem hiding this comment.
I've had to rebase locally to bring #221477 (to be able to cross-check clang with avr-gcc) - seems we're generating even better code!
I've left two small comments to clarify why we have to call setFrameAddressIsTaken() and setReturnAddressIsTaken(), other than that LGTM.
Contributor
|
Very nice! I see that pipeline failed on some spurious network error:
Let me restart the pipeline and, if it passes, I'll merge the code. |
Patryk27
approved these changes
Sep 18, 2026
Patryk27
force-pushed
the
avr-fix-issue-179991
branch
from
September 18, 2026 19:39
24a4fd1 to
625d770
Compare
Patryk27
enabled auto-merge (squash)
September 18, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #179991