Skip to content

Fix unused parameter for add_bitcode_entrypoint_library for GPU Libc #198458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinge90 merged 2 commits into from
May 19, 2026
Merged

Fix unused parameter for add_bitcode_entrypoint_library for GPU Libc #198458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b04547
Fix unused parameter for add_bitcode_entrypoint_library for GPU Libc
jinge90 May 19, 2026
8c2be35
Merge branch 'main' into nfc_libc_cmake
jinge90 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libc/cmake/modules/LLVMLibCLibraryRules.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ endfunction()
# A rule to build a library from a collection of entrypoint objects and bundle
# it in a single LLVM-IR bitcode file.
# Usage:
# add_gpu_entrypoint_library(
# add_bitcode_entrypoint_library(
# DEPENDS <list of add_entrypoint_object targets>
# )
function(add_bitcode_entrypoint_library target_name base_target_name)
Expand Down Expand Up @@ -116,6 +116,7 @@ function(add_bitcode_entrypoint_library target_name base_target_name)
target_link_options(${target_name} PRIVATE "${LIBC_COMPILE_OPTIONS_DEFAULT}"
"-r" "-nostdlib" "-flto" "-Wl,--lto-emit-llvm")
endif()
add_dependencies(${base_target_name} ${target_name})
endfunction(add_bitcode_entrypoint_library)

# A rule to build a library from a collection of entrypoint objects.
Expand Down
Loading