[lldb] Skip TestBytecode tests on Windows#197955
Merged
Merged
Conversation
This patch must fix broken tests after llvm#197808 on the lldb-x86_64-win buildbot.
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesThis patch must fix broken tests after #197808 on Windows (the lldb-x86_64-win buildbot). Full diff: https://github.com/llvm/llvm-project/pull/197955.diff 2 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/bytecode-summary/TestBytecodeSummary.py b/lldb/test/API/functionalities/data-formatter/bytecode-summary/TestBytecodeSummary.py
index c32a4517b2b82..43a7e1abc3b0b 100644
--- a/lldb/test/API/functionalities/data-formatter/bytecode-summary/TestBytecodeSummary.py
+++ b/lldb/test/API/functionalities/data-formatter/bytecode-summary/TestBytecodeSummary.py
@@ -5,6 +5,7 @@
class TestCase(TestBase):
+ @skipIfWindows
def test(self):
self.build()
if self.TraceOn():
diff --git a/lldb/test/API/functionalities/data-formatter/bytecode-synthetic/TestBytecodeSynthetic.py b/lldb/test/API/functionalities/data-formatter/bytecode-synthetic/TestBytecodeSynthetic.py
index 21228c61e1427..1c0f05f20182e 100644
--- a/lldb/test/API/functionalities/data-formatter/bytecode-synthetic/TestBytecodeSynthetic.py
+++ b/lldb/test/API/functionalities/data-formatter/bytecode-synthetic/TestBytecodeSynthetic.py
@@ -5,6 +5,7 @@
class TestCase(TestBase):
+ @skipIfWindows
def test_synthetic(self):
self.build()
if self.TraceOn():
@@ -21,6 +22,7 @@ def test_synthetic(self):
self.expect("v acc", matching=False, substrs=["password"])
+ @skipIfWindows
def test_update_reuse(self):
self.build()
|
Contributor
|
@charles-zablit can figure it out if @kastiglione doesn't have Windows to hand. If it's a "real" problem (not a test expectation), open an issue for it. In the meantime, let's fix the bots. |
DavidSpickett
approved these changes
May 15, 2026
pedroMVicente
pushed a commit
to pedroMVicente/llvm-project
that referenced
this pull request
May 19, 2026
This patch must fix broken tests after llvm#197808 on Windows (the lldb-x86_64-win buildbot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch must fix broken tests after #197808 on Windows (the lldb-x86_64-win buildbot).