Skip to content

[Codegen] Relax start stop test so riscv passes#190171

Closed
gbaraldi wants to merge 1 commit into
llvm:mainfrom
gbaraldi:gb/riscv-fix
Closed

[Codegen] Relax start stop test so riscv passes#190171
gbaraldi wants to merge 1 commit into
llvm:mainfrom
gbaraldi:gb/riscv-fix

Conversation

@gbaraldi

@gbaraldi gbaraldi commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Since #77370 this test fails in riscv. That's because it runs Loop Terminator Folding and the next check is then wrong

…s. Riscv runs Loop Terminator Folding so it's slightly different
@llvmbot

llvmbot commented Apr 2, 2026

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-backend-x86

Author: Gabriel Baraldi (gbaraldi)

Changes

Since #77370 this test fails in riscv. That's because it runs Loop Terminator Folding and the next check is then wrong


Full diff: https://github.com/llvm/llvm-project/pull/190171.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/X86/llc-start-stop.ll (+1-1)
diff --git a/llvm/test/CodeGen/X86/llc-start-stop.ll b/llvm/test/CodeGen/X86/llc-start-stop.ll
index b9e5de51e5169..5c6fec65c8bac 100644
--- a/llvm/test/CodeGen/X86/llc-start-stop.ll
+++ b/llvm/test/CodeGen/X86/llc-start-stop.ll
@@ -18,7 +18,7 @@
 ; RUN: llc < %s -debug-pass=Structure -start-after=loop-reduce -o /dev/null 2>&1 | FileCheck %s -check-prefix=START-AFTER
 ; START-AFTER: -gc-lowering
 ; START-AFTER: FunctionPass Manager
-; START-AFTER-NEXT: Lower Garbage Collection Instructions
+; START-AFTER: Lower Garbage Collection Instructions
 
 ; RUN: llc < %s -debug-pass=Structure -start-before=loop-reduce -o /dev/null 2>&1 | FileCheck %s -check-prefix=START-BEFORE
 ; START-BEFORE: -machine-branch-prob -regalloc-evict -regalloc-priority -domtree

@gbaraldi

gbaraldi commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Oh I just saw #190151

@gbaraldi gbaraldi closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants