-
Notifications
You must be signed in to change notification settings - Fork 17.6k
[libc][math] Refactor copysign family to header-only #182137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
52bb9d2
[libc][math] Refactor copysign family to header-only
hulxv e1b46dc
Merge branch 'main' into refactor/header-only/copysign
hulxv fe5c7e2
fix: format
hulxv 1bd90bc
missed libc_common
hulxv 8c471e0
Merge branch 'main' into refactor/header-only/copysign
hulxv 29a809d
remove constexpr
hulxv bd7cf13
MISC_MATH_BASIC_OPS_OPT
hulxv 494e2ac
Merge branch 'main' into refactor/header-only/copysign
hulxv 28c0d05
correct flags
hulxv 0d54ea2
Qualify constant evaluation
bassiounix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- Shared copysign function --------------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGN_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGN_H | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysign.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysign; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGN_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- Shared copysignbf16 function ----------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGNBF16_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGNBF16_H | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysignbf16.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysignbf16; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGNBF16_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- Shared copysignf function -------------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGNF_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGNF_H | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysignf.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysignf; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGNF_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //===-- Shared copysignf128 function ----------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGNF128_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGNF128_H | ||
|
|
||
| #include "include/llvm-libc-types/float128.h" | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysignf128.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysignf128; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGNF128_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //===-- Shared copysignf16 function -----------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGNF16_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGNF16_H | ||
|
|
||
| #include "include/llvm-libc-macros/float16-macros.h" | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT16 | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysignf16.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysignf16; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT16 | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGNF16_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| //===-- Shared copysignl function -------------------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_MATH_COPYSIGNL_H | ||
| #define LLVM_LIBC_SHARED_MATH_COPYSIGNL_H | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/math/copysignl.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using math::copysignl; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_MATH_COPYSIGNL_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| //===-- Implementation header for copysign ----------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGN_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGN_H | ||
|
|
||
| #include "src/__support/FPUtil/ManipulationFunctions.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace math { | ||
|
|
||
| LIBC_INLINE LIBC_CONSTEXPR double copysign(double x, double y) { | ||
| #if defined(__LIBC_MISC_MATH_BASIC_OPS_OPT) && \ | ||
| !defined(LIBC_HAS_CONSTANT_EVALUATION) | ||
| return __builtin_copysign(x, y); | ||
| #else | ||
| return fputil::copysign(x, y); | ||
| #endif | ||
| } | ||
|
|
||
| } // namespace math | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGN_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| //===-- Implementation header for copysignbf16 ------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNBF16_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNBF16_H | ||
|
|
||
| #include "src/__support/FPUtil/ManipulationFunctions.h" | ||
| #include "src/__support/FPUtil/bfloat16.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace math { | ||
|
|
||
| LIBC_INLINE constexpr bfloat16 copysignbf16(bfloat16 x, bfloat16 y) { | ||
| return fputil::copysign(x, y); | ||
| } | ||
|
|
||
| } // namespace math | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNBF16_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| //===-- Implementation header for copysignf ---------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF_H | ||
|
|
||
| #include "src/__support/FPUtil/ManipulationFunctions.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace math { | ||
|
|
||
| LIBC_INLINE LIBC_CONSTEXPR float copysignf(float x, float y) { | ||
| #if defined(__LIBC_MISC_MATH_BASIC_OPS_OPT) && \ | ||
| !defined(LIBC_HAS_CONSTANT_EVALUATION) | ||
| return __builtin_copysignf(x, y); | ||
| #else | ||
| return fputil::copysign(x, y); | ||
| #endif | ||
| } | ||
|
|
||
| } // namespace math | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| //===-- Implementation header for copysignf128 ------------------*- C++ -*-===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF128_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF128_H | ||
|
|
||
| #include "include/llvm-libc-types/float128.h" | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #include "src/__support/FPUtil/ManipulationFunctions.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace math { | ||
|
|
||
| LIBC_INLINE constexpr float128 copysignf128(float128 x, float128 y) { | ||
| return fputil::copysign(x, y); | ||
| } | ||
|
|
||
| } // namespace math | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_MATH_COPYSIGNF128_H |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.