[flang] Add #include to fix MSVC build#161415
Merged
Merged
Conversation
flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others.
Member
|
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) Changesflang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others. Full diff: https://github.com/llvm/llvm-project/pull/161415.diff 1 Files Affected:
diff --git a/flang/lib/Evaluate/constant.cpp b/flang/lib/Evaluate/constant.cpp
index 0fa397b9c356d..8923ab114c737 100644
--- a/flang/lib/Evaluate/constant.cpp
+++ b/flang/lib/Evaluate/constant.cpp
@@ -10,6 +10,7 @@
#include "flang/Evaluate/expression.h"
#include "flang/Evaluate/shape.h"
#include "flang/Evaluate/type.h"
+#include "flang/Semantics/scope.h"
#include <string>
namespace Fortran::evaluate {
|
Contributor
Author
|
I think the original patch passed Windows CI but the Arm Windows build bot is failing due to a lack of definition of semantics::Scope. Please review soon. |
eugeneepshteyn
approved these changes
Sep 30, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/40883 Here is the relevant piece of the build log for the reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others.