[CodingStandard] Require Unix line endings for all files

[jurahul]

Require all files to use Unix line endings, formalizing an already followed convention.

[jurahul]

https://discourse.llvm.org/t/llvm-source-file-line-endings/81388/12 for reference

[rnk]

Adding clang-format checks seems like a good next step, but I don't see any reason to block landing this on that.

[jurahul]

Thanks. I'll leave it open for a few days for folks to comment (here or in the thread).

[jh7370]

+1 to the general idea, but as nikic has mentioned, it's my understanding that the line endings should be \n for all cases except for a few very specific exceptions, which probably don't need enumerating in the coding standard (assuming they are obvious from the specific contexts, i.e. the tests that rely on line endings).

[jurahul]

I also removed the use of the word "style" as just using Unix line endings is sufficient.

[nikic]

LGTM

[jh7370]

LGTM, but you should change the PR title and description to remove the use of "source" too, so that it doesn't appear in the commit message.

[jurahul]

LGTM, but you should change the PR title and description to remove the use of "source" too, so that it doesn't appear in the commit message.

Done.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/21609

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-unit :: Core/./LLDBCoreTests/97/470 (2452 of 3698)
PASS: lldb-unit :: Core/./LLDBCoreTests/98/470 (2453 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/1/76 (2454 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/0/76 (2455 of 3698)
PASS: lldb-unit :: Core/./LLDBCoreTests/99/470 (2456 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/13/76 (2457 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/12/76 (2458 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/15/76 (2459 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/14/76 (2460 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/11/76 (2461 of 3698)
FAIL: lldb-unit :: DAP/./DAPTests/10/76 (2462 of 3698)
******************** TEST 'lldb-unit :: DAP/./DAPTests/10/76' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/DAP/./DAPTests-lldb-unit-3711734-10-76.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=76 GTEST_SHARD_INDEX=10 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/DAP/./DAPTests
--

Script:
--
/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb/unittests/DAP/./DAPTests --gtest_filter=DisconnectRequestHandlerTest.DisconnectTriggersTerminateCommands
--
../llvm-project/lldb/unittests/DAP/Handler/DisconnectTest.cpp:51: Failure
Actual function call count doesn't match EXPECT_CALL(client, Received(Output("1\n")))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

../llvm-project/lldb/unittests/DAP/Handler/DisconnectTest.cpp:52: Failure
Actual function call count doesn't match EXPECT_CALL(client, Received(Output("2\n")))...
         Expected: to be called twice
           Actual: called once - unsatisfied and active


../llvm-project/lldb/unittests/DAP/Handler/DisconnectTest.cpp:51
Actual function call count doesn't match EXPECT_CALL(client, Received(Output("1\n")))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

../llvm-project/lldb/unittests/DAP/Handler/DisconnectTest.cpp:52
Actual function call count doesn't match EXPECT_CALL(client, Received(Output("2\n")))...
         Expected: to be called twice
           Actual: called once - unsatisfied and active



********************
PASS: lldb-unit :: DAP/./DAPTests/19/76 (2463 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/17/76 (2464 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/16/76 (2465 of 3698)
PASS: lldb-unit :: DAP/./DAPTests/18/76 (2466 of 3698)