Skip to content

[Docs][RISCV]Remove experimental from Smctr, Ssctr,Sdext and Sdtrig#161058

Merged
ChunyuLiao merged 3 commits into
llvm:mainfrom
ChunyuLiao:doc
Sep 30, 2025
Merged

[Docs][RISCV]Remove experimental from Smctr, Ssctr,Sdext and Sdtrig#161058
ChunyuLiao merged 3 commits into
llvm:mainfrom
ChunyuLiao:doc

Conversation

@ChunyuLiao

Copy link
Copy Markdown
Member

No description provided.

@llvmbot

llvmbot commented Sep 28, 2025

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-backend-risc-v

Author: Liao Chunyu (ChunyuLiao)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/161058.diff

1 Files Affected:

  • (modified) llvm/docs/RISCVUsage.rst (+4-6)
diff --git a/llvm/docs/RISCVUsage.rst b/llvm/docs/RISCVUsage.rst
index 7b1a6ce834919..d3c62c1b0d821 100644
--- a/llvm/docs/RISCVUsage.rst
+++ b/llvm/docs/RISCVUsage.rst
@@ -120,6 +120,8 @@ on support follow.
      ``H``             Assembly Support
      ``M``             Supported
      ``Q``             Assembly Support
+     ``Sdext``         Assembly Support
+     ``Sdtrig``        Assembly Support
      ``Sha``           Supported
      ``Shcounterenw``  Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
      ``Shgatpa``       Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
@@ -132,6 +134,7 @@ on support follow.
      ``Smcdeleg``      Supported
      ``Smcntrpmf``     Supported
      ``Smcsrind``      Supported
+     ``Smctr``         Assembly Support
      ``Smdbltrp``      Supported
      ``Smepmp``        Supported
      ``Smmpm``         Supported
@@ -144,6 +147,7 @@ on support follow.
      ``Sscofpmf``      Assembly Support
      ``Sscounterenw``  Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
      ``Sscsrind``      Supported
+     ``Ssctr``         Assembly Support
      ``Ssdbltrp``      Supported
      ``Ssnpm``         Supported
      ``Sspm``          Supported
@@ -337,12 +341,6 @@ The primary goal of experimental support is to assist in the process of ratifica
 ``experimental-zvbc32e``, ``experimental-zvkgs``
   LLVM implements the `0.7 release specification <https://github.com/user-attachments/files/16450464/riscv-crypto-spec-vector-extra_v0.0.7.pdf>`__.
 
-``experimental-sdext``, ``experimental-sdtrig``
-  LLVM implements the `1.0-rc4 specification <https://github.com/riscv/riscv-debug-spec/releases/download/1.0.0-rc4/riscv-debug-specification.pdf>`__.
-
-``experimental-smctr``, ``experimental-ssctr``
-  LLVM implements the `1.0-rc3 specification <https://github.com/riscv/riscv-control-transfer-records/releases/tag/v1.0_rc3>`__.
-
 ``experimental-svukte``
   LLVM implements the `0.3 draft specification <https://github.com/riscv/riscv-isa-manual/pull/1564>`__.
 

@sunshaoce

Copy link
Copy Markdown
Contributor

Can we also give these extensions a See note like Sscounterenw? I think this is very convenient.

@ChunyuLiao

Copy link
Copy Markdown
Member Author

Can we also give these extensions a See note like Sscounterenw? I think this is very convenient.

They have assembly instructions, and are outside the scope of the riscv profile.
#120936
#105148

Do we need to add the spec document to RISCVUsage.rst?
https://github.com/riscv/riscv-debug-spec/releases
https://github.com/riscv/riscv-control-transfer-records/releases/tag/v1.0_rc3

@sunshaoce

Copy link
Copy Markdown
Contributor

Do we need to add the spec document to RISCVUsage.rst? https://github.com/riscv/riscv-debug-spec/releases https://github.com/riscv/riscv-control-transfer-records/releases/tag/v1.0_rc3

Yes, adding a .. _riscv-debug-spec-note: would be good. That way readers have a clear reference to the spec.

@ChunyuLiao

Copy link
Copy Markdown
Member Author

Add Smctr, Ssctr,Sdext and Sdtrig spec docs. We can list the specs of other extensions, if needed.

Comment thread llvm/docs/RISCVUsage.rst Outdated
.. _riscv-extensions-specifications-note:

``Sdext``, ``Sdtrig`` `The RISC-V Debug Specification <https://github.com/riscv/riscv-debug-spec/releases/download/1.0/riscv-debug-specification.pdf>`__.
``Smctr``, ``Ssctr`` `RISC-V Control Transfer Records <https://github.com/riscv/riscv-control-transfer-records/releases/download/v1.0_rc3/riscv-ctr-v1.0_rc3.pdf>`__.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smctr and Ssctr have been integrated into the riscv-isa-manual I think.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete Smctr and Ssctr spec.

@sunshaoce sunshaoce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChunyuLiao ChunyuLiao merged commit c389f50 into llvm:main Sep 30, 2025
10 checks passed
@ChunyuLiao ChunyuLiao deleted the doc branch September 30, 2025 11:52
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants