[Github] Build CI Containers in Stacked PRs#149346
Merged
boomanaiden154 merged 1 commit intoJul 18, 2025
Merged
Conversation
Currently the pull_request event on the build CI container workflows are restricted to main. This prevents building them on stacked PRs. This is a bit annoying because we do not get the CI to test that everything is working until all of the base PRs have landed and the target branch becomes main.
boomanaiden154
requested review from
Keenuts,
cmtice,
dschuff,
gburgessiv,
lnihlen and
tstellar
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesCurrently the pull_request event on the build CI container workflows are restricted to main. This prevents building them on stacked PRs. This is a bit annoying because we do not get the CI to test that everything is working until all of the base PRs have landed and the target branch becomes main. Full diff: https://github.com/llvm/llvm-project/pull/149346.diff 2 Files Affected:
diff --git a/.github/workflows/build-ci-container-windows.yml b/.github/workflows/build-ci-container-windows.yml
index 59079f057d021..f76c69f29fb30 100644
--- a/.github/workflows/build-ci-container-windows.yml
+++ b/.github/workflows/build-ci-container-windows.yml
@@ -11,8 +11,6 @@ on:
- .github/workflows/build-ci-container-windows.yml
- '.github/workflows/containers/github-action-ci-windows/**'
pull_request:
- branches:
- - main
paths:
- .github/workflows/build-ci-container-windows.yml
- '.github/workflows/containers/github-action-ci-windows/**'
diff --git a/.github/workflows/build-ci-container.yml b/.github/workflows/build-ci-container.yml
index 3159aae32ca51..7f01264af8534 100644
--- a/.github/workflows/build-ci-container.yml
+++ b/.github/workflows/build-ci-container.yml
@@ -11,8 +11,6 @@ on:
- .github/workflows/build-ci-container.yml
- '.github/workflows/containers/github-action-ci/**'
pull_request:
- branches:
- - main
paths:
- .github/workflows/build-ci-container.yml
- '.github/workflows/containers/github-action-ci/**'
|
Keenuts
approved these changes
Jul 18, 2025
This was referenced Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the pull_request event on the build CI container workflows are restricted to main. This prevents building them on stacked PRs. This is a bit annoying because we do not get the CI to test that everything is working until all of the base PRs have landed and the target branch becomes main.