Skip to content

[llvm][blake3] Prefix blake3_hash4_neon#149139

Closed
ilovepi wants to merge 1 commit into
mainfrom
users/ilovepi/blake3-neon
Closed

[llvm][blake3] Prefix blake3_hash4_neon#149139
ilovepi wants to merge 1 commit into
mainfrom
users/ilovepi/blake3-neon

Conversation

@ilovepi

@ilovepi ilovepi commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

In #147948 blake3_hash4_neon became a public symbol (no longer static).
Like other APIs introduced, it was not prefixed, resulting in conflicts if
libblake3 and LLVM are both linked statically into the same binary.

In #147948 blake3_hash4_neon became a public symbol (no longer static).
Like other APIs introduced, it was not prefixed, resulting in conflicts if
libblake3 and LLVM are both linked statically into the same binary.
@ilovepi ilovepi requested review from akyrtzi, nikic and slydiman July 16, 2025 16:40

ilovepi commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot

llvmbot commented Jul 16, 2025

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-llvm-support

Author: Paul Kirth (ilovepi)

Changes

In #147948 blake3_hash4_neon became a public symbol (no longer static).
Like other APIs introduced, it was not prefixed, resulting in conflicts if
libblake3 and LLVM are both linked statically into the same binary.


Full diff: https://github.com/llvm/llvm-project/pull/149139.diff

1 Files Affected:

  • (modified) llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h (+1)
diff --git a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
index d24657465dd8f..efdd65b692fbf 100644
--- a/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
+++ b/llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h
@@ -41,5 +41,6 @@
 #define blake3_hash_many_avx512 llvm_blake3_hash_many_avx512
 #define _blake3_hash_many_avx512 _llvm_blake3_hash_many_avx512
 #define blake3_hash_many_neon llvm_blake3_hash_many_neon
+#define blake3_hash4_neon llvm_blake3_hash4_neon
 
 #endif /* LLVM_BLAKE3_PREFIX_H */

@nikic nikic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been fixed in #149046.

ilovepi commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Thanks. I didn't notice that was fixed there. Our Integration CI where this shows up is a bit slower.

@ilovepi ilovepi closed this Jul 16, 2025
@github-actions github-actions Bot deleted the users/ilovepi/blake3-neon branch February 25, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants