Skip to content

TableGen: Fixed the string table definitions visibility.#148946

Merged
vzakhari merged 2 commits into
llvm:mainfrom
vzakhari:buildbots_after_148839
Jul 15, 2025
Merged

TableGen: Fixed the string table definitions visibility.#148946
vzakhari merged 2 commits into
llvm:mainfrom
vzakhari:buildbots_after_148839

Conversation

@vzakhari

Copy link
Copy Markdown
Contributor

This fixes the buildbots issues reported in #148839.

This fixes the buildbots issues reported in llvm#148839.
@llvmbot

llvmbot commented Jul 15, 2025

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-tablegen

Author: Slava Zakharin (vzakhari)

Changes

This fixes the buildbots issues reported in #148839.


Full diff: https://github.com/llvm/llvm-project/pull/148946.diff

1 Files Affected:

  • (modified) llvm/lib/TableGen/StringToOffsetTable.cpp (+3-2)
diff --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cpp
index d6d2c2590389a..41f82caa12f82 100644
--- a/llvm/lib/TableGen/StringToOffsetTable.cpp
+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp
@@ -83,10 +83,11 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS,
 #pragma GCC diagnostic pop
 #endif
 
-{1}constexpr llvm::StringTable
+{1} llvm::StringTable
 {2}{0} = {0}Storage;
 )",
-                Name, ClassPrefix.empty() ? "static " : "", ClassPrefix);
+                Name, ClassPrefix.empty() ? "static constexpr" : "const",
+                ClassPrefix);
 }
 
 void StringToOffsetTable::EmitString(raw_ostream &O) const {

@jurahul

jurahul commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Can you also update the lit test?

@jurahul

jurahul commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Thanks for fixing the failure.

@vzakhari vzakhari merged commit e685e4a into llvm:main Jul 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants