Minor formatting fix in 'generate_feature_test_macro_components' by elsteveogrande · Pull Request #148889 · llvm/llvm-project

elsteveogrande · 2025-07-15T16:51:18Z

Fixes a small annoyance where generated files have a format which does not agree with the one checked during code-formatter in CI.

For example libcxx-generate-files updates (among possibly others) the *.version.compile.pass.cpp files. Previously these files contained an extra newline which would fail the code format check. If you update that file manually to remove just that extra trailing newline, then check-generated-output will fail due to the file's contents differing from what's expected.

Contains a number of changes: one actual change to the py script, and lots of resulting whitespace changes.

My process for this was:

Update generate_feature_test_macro_components: just remove an extra newline which causes the code-format step to fail
Run $NINJA libcxx-generate-files to rebuild all these .version.pass.cpp's
Watch this PR's CI run to ensure things pass (i.e. this didn't break things worse)

llvmbot · 2025-07-15T17:04:39Z

@llvm/pr-subscribers-libcxx

Author: Steve O'Brien (elsteveogrande)

Changes

Fixes a small annoyance where generated files have a format which does not agree with the one checked during code-formatter in CI.

For example libcxx-generate-files updates (among possibly others) the *.version.compile.pass.cpp files. Previously these files contained an extra newline which would fail the code format check. If you update that file manually to remove just that extra trailing newline, then check-generated-output will fail due to the file's contents differing from what's expected.

Contains a number of changes: one actual change to the py script, and lots of resulting whitespace changes.

My process for this was:

Update generate_feature_test_macro_components: just remove an extra newline which causes the code-format step to fail
Run $NINJA libcxx-generate-files to rebuild all these .version.pass.cpp's
Watch this PR's CI run to ensure things pass (i.e. this didn't break things worse)

Patch is 41.33 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/148889.diff

76 Files Affected:

(modified) libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/mdspan.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/memory.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/memory_resource.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/mutex.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/new.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/numbers.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/numeric.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/optional.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/ostream.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/print.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/queue.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/random.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/ranges.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/ratio.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/regex.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/scoped_allocator.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/semaphore.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/set.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/shared_mutex.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/source_location.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/span.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/sstream.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/stack.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/stdatomic.h.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/stop_token.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/string.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/string_view.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/syncstream.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/thread.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/tuple.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/type_traits.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/typeinfo.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/unordered_map.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/unordered_set.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/utility.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/variant.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/vector.version.compile.pass.cpp (-1)
(modified) libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp (-1)
(modified) libcxx/utils/generate_feature_test_macro_components.py (-1)

diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp
index 488bc468bce79..bc479f1bcb1e0 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp
@@ -459,4 +459,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp
index 7f3d6394749b4..fe0e6bd17f94d 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp
@@ -69,4 +69,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp
index 9e50976e5cc2c..30efb61893a1b 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp
@@ -171,4 +171,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
index e6145bbed5af9..3470e2b28bc40 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
@@ -420,4 +420,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp
index 0d025923728b7..a908c417df48b 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp
@@ -86,4 +86,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp
index 35033419ac440..cad025eee3373 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp
@@ -195,4 +195,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp
index ea61d99736208..8799a1f7d14e5 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp
@@ -90,4 +90,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp
index 52b02562dc5ab..6ec3037c9ea45 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp
@@ -123,4 +123,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp
index 1453938b01da0..d5d7a5da4a64d 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp
@@ -108,4 +108,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp
index 507c7ab6084f8..26ebe1e3ad6b1 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp
@@ -204,4 +204,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp
index 56759a88a7348..907535a087de2 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp
@@ -66,4 +66,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp
index b5efa984b456a..9a3a644ca5d64 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp
@@ -105,4 +105,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp
index d9b2c43ecbd12..e4058c2348f9b 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp
@@ -66,4 +66,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp
index b472b205f89d5..24a9eca1e2346 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp
@@ -66,4 +66,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp
index ccc034418cde0..bc65a7f3cae00 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp
@@ -69,4 +69,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp
index f250798c129ea..600fa2eb2e4f5 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp
@@ -75,4 +75,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp
index 675c918cac417..8445aa3cf0c48 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/cstring.version.compile.pass.cpp
@@ -66,4 +66,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp
index eff8689be9fb8..b634f3253093e 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp
@@ -201,4 +201,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp
index 60d6418c7459a..11d5735007f5b 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp
@@ -69,4 +69,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp
index b843aab42e6eb..77a6455e23302 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp
@@ -126,4 +126,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp
index 9c7a84f145dde..74cf85ea9029f 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/expected.version.compile.pass.cpp
@@ -129,4 +129,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp
index 98acf8bb602ca..9c28db3bb0869 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp
@@ -179,4 +179,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp
index 19e2fd79a4295..9c06eee27e0c8 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/flat_map.version.compile.pass.cpp
@@ -63,4 +63,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp
index d078f9bda23c9..5985bdc2d7d4f 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/flat_set.version.compile.pass.cpp
@@ -63,4 +63,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp
index 3fa4334143b1a..77730f17fd9c6 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp
@@ -147,4 +147,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp
index 05f903dccafe7..d2082946597cb 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp
@@ -297,4 +297,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp
index ee32346d61080..f67adb0de1ded 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/fstream.version.compile.pass.cpp
@@ -68,4 +68,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp
index 8c0820681188d..b7b7d0334830a 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp
@@ -579,4 +579,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp
index 37deba7c9661a..4de327cbfa26b 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp
@@ -104,4 +104,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp
index 179c3ce066b6f..68816936c55e9 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/ios.version.compile.pass.cpp
@@ -65,4 +65,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp
index 46238896f79c3..a1178b22776f1 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp
@@ -86,4 +86,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp
index 75dcb18a5428c..e9805ed4b1542 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp
@@ -315,4 +315,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp
index 6857c54460650..8e105648becef 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp
@@ -86,4 +86,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp
index 0b3d6f5d2bd9c..f4cc8db0f54cb 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp
@@ -84,4 +84,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp
index d10c61c0e9cf4..1407d74e03aa2 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp
@@ -297,4 +297,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp
index e1a04d1b0e087..f516881651b23 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp
@@ -86,4 +86,3 @@
 #endif // TEST_STD_VER > 23
 
 // clang-format on
-
diff --git a/libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp b/libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp
index 4044c2b1b2e0f..3db3861c72b5c 100644
--- a/libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp
+++ b/libcxx/test/std/language.support/support.limits/support.limits.general/map....
[truncated]

ldionne

I can confirm that files like libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp are mis-formatted according to our clang-format rules.

This seems to have been broken by #134543, although I can't find a rationale for that part of the change. Consequently, LGTM. Thanks for fixing!

elsteveogrande · 2025-07-15T21:39:48Z

Thanks @ldionne ! CI is looking good (except for one stuck job ...)

Minor formatting fix in 'generate_feature_test_macro_components'

0daf308

elsteveogrande requested a review from a team as a code owner July 15, 2025 16:51

llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 15, 2025

ldionne approved these changes Jul 15, 2025

View reviewed changes

philnik777 merged commit a89e6f6 into llvm:main Jul 16, 2025
79 checks passed

This was referenced Jul 23, 2025

test abhinavgaba/llvm-project#2

Closed

Add dataFence plugin interface abhinavgaba/llvm-project#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor formatting fix in 'generate_feature_test_macro_components'#148889

Minor formatting fix in 'generate_feature_test_macro_components'#148889
philnik777 merged 1 commit into
llvm:mainfrom
elsteveogrande:minor-whitespace-fix

elsteveogrande commented Jul 15, 2025

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

ldionne left a comment

Uh oh!

elsteveogrande commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

elsteveogrande commented Jul 15, 2025

Uh oh!

llvmbot commented Jul 15, 2025

Uh oh!

ldionne left a comment

Choose a reason for hiding this comment

Uh oh!

elsteveogrande commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants