TableGen: Avoid emitting trailing whitespace in StringToOffsetTable

[arsenm]

No description provided.

[arsenm]

• TableGen: Avoid emitting trailing whitespace in StringToOffsetTable #148840 👈 (View in Graphite)
• TableGen: Use StringOffsetTable for RuntimeLibcall names #148839
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-tablegen

Author: Matt Arsenault (arsenm)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/148840.diff

1 Files Affected:

• (modified) llvm/lib/TableGen/StringToOffsetTable.cpp (+1-1)

diff --git a/llvm/lib/TableGen/StringToOffsetTable.cpp b/llvm/lib/TableGen/StringToOffsetTable.cpp
index 9fb41485db745..d6d2c2590389a 100644
--- a/llvm/lib/TableGen/StringToOffsetTable.cpp
+++ b/llvm/lib/TableGen/StringToOffsetTable.cpp
@@ -38,7 +38,7 @@ void StringToOffsetTable::EmitStringTableDef(raw_ostream &OS,
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Woverlength-strings"
 #endif
-{} constexpr char {}{}Storage[] = )",
+{} constexpr char {}{}Storage[] =)",
                 ClassPrefix.empty() ? "static" : "", ClassPrefix, Name);
 
   // MSVC silently miscompiles string literals longer than 64k in some

[nikic]

I think you'd want to add a whitespace before "{\n" a few lines below then?

[arsenm]

I don't think so, it looks right as is. Every entry ends up on its own line, though under-indented

[nikic]

I'm referring to the >64k case, which now would print ={ instead of = { I think. But it doesn't particularly matter...

[nikic]

I'm referring to the >64k case, which now would print ={ instead of = { I think. But it doesn't particularly matter...

[arsenm]

Merge activity

• Jul 15, 2:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 15, 2:25 PM UTC: Graphite rebased this pull request as part of a merge.
• Jul 15, 2:27 PM UTC: @arsenm merged this pull request with Graphite.