ARM: Handle vldrh and vstrh in stack access hooks#120527
Merged
Merged
Conversation
This is to help avoid regressions in a future regalloc patch. I do not see the vstrh case appear in tests. There also appear to be other cases unhandled here, like LDRBi12.
Member
|
@llvm/pr-subscribers-backend-arm Author: Matt Arsenault (arsenm) ChangesThis is to help avoid regressions in a future regalloc patch. I do not see the vstrh case appear in tests. There also appear Full diff: https://github.com/llvm/llvm-project/pull/120527.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
index e6b37dd9161685..e3e2e83fd5c7eb 100644
--- a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
+++ b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
@@ -1330,6 +1330,7 @@ Register ARMBaseInstrInfo::isStoreToStackSlot(const MachineInstr &MI,
case ARM::tSTRspi:
case ARM::VSTRD:
case ARM::VSTRS:
+ case ARM::VSTRH:
case ARM::VSTR_P0_off:
case ARM::VSTR_FPSCR_NZCVQC_off:
case ARM::MVE_VSTRWU32:
@@ -1588,6 +1589,7 @@ Register ARMBaseInstrInfo::isLoadFromStackSlot(const MachineInstr &MI,
case ARM::tLDRspi:
case ARM::VLDRD:
case ARM::VLDRS:
+ case ARM::VLDRH:
case ARM::VLDR_P0_off:
case ARM::VLDR_FPSCR_NZCVQC_off:
case ARM::MVE_VLDRWU32:
|
This was referenced Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is to help avoid regressions in a future regalloc patch.
I do not see the vstrh case appear in tests. There also appear
to be other cases unhandled here, like LDRBi12.