Skip to content

ARM: Handle vldrh and vstrh in stack access hooks#120527

Merged
arsenm merged 1 commit into
mainfrom
users/arsenm/arm-implement-stack-access-vldrh-vstrh
Dec 19, 2024
Merged

ARM: Handle vldrh and vstrh in stack access hooks#120527
arsenm merged 1 commit into
mainfrom
users/arsenm/arm-implement-stack-access-vldrh-vstrh

Conversation

@arsenm

@arsenm arsenm commented Dec 19, 2024

Copy link
Copy Markdown
Contributor

This is to help avoid regressions in a future regalloc patch.

I do not see the vstrh case appear in tests. There also appear
to be other cases unhandled here, like LDRBi12.

This is to help avoid regressions in a future regalloc patch.

I do not see the vstrh case appear in tests. There also appear
to be other cases unhandled here, like LDRBi12.

arsenm commented Dec 19, 2024

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm marked this pull request as ready for review December 19, 2024 06:50
@llvmbot

llvmbot commented Dec 19, 2024

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-backend-arm

Author: Matt Arsenault (arsenm)

Changes

This is to help avoid regressions in a future regalloc patch.

I do not see the vstrh case appear in tests. There also appear
to be other cases unhandled here, like LDRBi12.


Full diff: https://github.com/llvm/llvm-project/pull/120527.diff

1 Files Affected:

  • (modified) llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp (+2)
diff --git a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
index e6b37dd9161685..e3e2e83fd5c7eb 100644
--- a/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
+++ b/llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
@@ -1330,6 +1330,7 @@ Register ARMBaseInstrInfo::isStoreToStackSlot(const MachineInstr &MI,
   case ARM::tSTRspi:
   case ARM::VSTRD:
   case ARM::VSTRS:
+  case ARM::VSTRH:
   case ARM::VSTR_P0_off:
   case ARM::VSTR_FPSCR_NZCVQC_off:
   case ARM::MVE_VSTRWU32:
@@ -1588,6 +1589,7 @@ Register ARMBaseInstrInfo::isLoadFromStackSlot(const MachineInstr &MI,
   case ARM::tLDRspi:
   case ARM::VLDRD:
   case ARM::VLDRS:
+  case ARM::VLDRH:
   case ARM::VLDR_P0_off:
   case ARM::VLDR_FPSCR_NZCVQC_off:
   case ARM::MVE_VLDRWU32:

@ostannard ostannard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arsenm arsenm merged commit 5fb8d70 into main Dec 19, 2024
@arsenm arsenm deleted the users/arsenm/arm-implement-stack-access-vldrh-vstrh branch December 19, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants