Skip to content

[MemProf] Add quotes around FileCheck pattern#120481

Merged
teresajohnson merged 1 commit into
llvm:mainfrom
teresajohnson:memprof_fix_Bot
Dec 18, 2024
Merged

[MemProf] Add quotes around FileCheck pattern#120481
teresajohnson merged 1 commit into
llvm:mainfrom
teresajohnson:memprof_fix_Bot

Conversation

@teresajohnson

Copy link
Copy Markdown
Contributor

Some bots are failing with 2916352,
likely due to the escapes in the FileCheck pattern. Add extra quotes to
try to fix this.
E.g. https://lab.llvm.org/buildbot/#/builders/46/builds/9442

Some bots are failing with 2916352,
likely due to the escapes in the FileCheck pattern. Add extra quotes to
try to fix this.
E.g. https://lab.llvm.org/buildbot/#/builders/46/builds/9442
@llvmbot llvmbot added the LTO Link time optimization (regular/full LTO or ThinLTO) label Dec 18, 2024
@teresajohnson teresajohnson merged commit 00840fb into llvm:main Dec 18, 2024
@llvmbot

llvmbot commented Dec 18, 2024

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-lto

Author: Teresa Johnson (teresajohnson)

Changes

Some bots are failing with 2916352,
likely due to the escapes in the FileCheck pattern. Add extra quotes to
try to fix this.
E.g. https://lab.llvm.org/buildbot/#/builders/46/builds/9442


Full diff: https://github.com/llvm/llvm-project/pull/120481.diff

1 Files Affected:

  • (modified) llvm/test/ThinLTO/X86/memprof-missing-callsite.ll (+1-1)
diff --git a/llvm/test/ThinLTO/X86/memprof-missing-callsite.ll b/llvm/test/ThinLTO/X86/memprof-missing-callsite.ll
index 3179df61a26eb7..e7fbb3c0bad2c0 100644
--- a/llvm/test/ThinLTO/X86/memprof-missing-callsite.ll
+++ b/llvm/test/ThinLTO/X86/memprof-missing-callsite.ll
@@ -28,7 +28,7 @@
 ; RUN:	-pass-remarks=memprof-context-disambiguation -save-temps \
 ; RUN:	-o %t.out 2>&1 | FileCheck %s --implicit-check-not "call in clone _Z3foov" \
 ; RUN:  --check-prefix=SIZESUNHINTED
-; RUN: llvm-dis %t.out.1.4.opt.bc -o - | FileCheck %s --implicit-check-not \"memprof\"=\"cold\"
+; RUN: llvm-dis %t.out.1.4.opt.bc -o - | FileCheck %s --implicit-check-not "\"memprof\"=\"cold\""
 
 source_filename = "memprof-missing-callsite.ll"
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LTO Link time optimization (regular/full LTO or ThinLTO)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants