Skip to content

[LLVM] Update maintainers for binary utilities#120428

Merged
nikic merged 1 commit into
llvm:mainfrom
nikic:objcopy-maintainer
Dec 19, 2024
Merged

[LLVM] Update maintainers for binary utilities#120428
nikic merged 1 commit into
llvm:mainfrom
nikic:objcopy-maintainer

Conversation

@nikic

@nikic nikic commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

See developer policy for context on the maintainers terminology.

We currently list @jakehehrlich as the maintainer for llvm-objcopy / ObjCopy, but he hasn't been involved with LLVM for more than 5 years.

Looking through the contribution history it's not very obvious who to nominate as a replacement here, but I think @MaskRay is the main person with regular contributions in this area.

@nikic nikic requested a review from MaskRay December 18, 2024 14:01
@MaskRay

MaskRay commented Dec 18, 2024

Copy link
Copy Markdown
Member

llvm-objcopy is a stable, largely mature drop-in replacement for GNU objcopy, including LLVM extensions.
It is so stable that it doesn't receive much active development.

I suggest that we replace the specific tool llvm-objcopy/ObjCopy with the broader "LLVM binary utilities".
(In addition, we have a llvm:binary-utilities new PR label, but not for llvm-objcopy.)

@jh7370 has been the most active reviewer in this area, so I'd like to nominate him as well.
(As we allow multiple maintainers, you may name both of us.)
While James might be less active in patch contribution, his provides invaluable code review, which is essential to catch potential issues and ensure code maintainability

@nikic

nikic commented Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

llvm-objcopy is a stable, largely mature drop-in replacement for GNU objcopy, including LLVM extensions. It is so stable that it doesn't receive much active development.

I suggest that we replace the specific tool llvm-objcopy/ObjCopy with the broader "LLVM binary utilities". (In addition, we have a llvm:binary-utilities new PR label, but not for llvm-objcopy.)

Thanks, that makes a lot of sense.

@jh7370 has been the most active reviewer in this area, so I'd like to nominate him as well. (As we allow multiple maintainers, you may name both of us.) While James might be less active in patch contribution, his provides invaluable code review, which is essential to catch potential issues and ensure code maintainability

Thanks for pointing that out, I've added @jh7370 now! Unfortunately GitHub only makes it easy to find people who often commit to an area, but not people who often review :(

@nikic nikic changed the title [LLVM] Update llvm-objcopy maintainer [LLVM] Update maintainers for binary utilities Dec 18, 2024
@nikic nikic requested a review from jh7370 December 18, 2024 17:35

@MaskRay MaskRay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jh7370 jh7370 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to accept this myself.

There are a handful of what some people will consider "binary utilities" that I don't contribute to (i.e. review), but I think this is a reasonable thing nonetheless.

@nikic nikic force-pushed the objcopy-maintainer branch 2 times, most recently from 1dd806b to e3f6a4c Compare December 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants