Update to new builder format.#8785
Merged
Merged
Conversation
Basically did set(CMAKE_CXX_CLANG_TIDY local/clang-tidy -checks=-*,llvm-use-new-mlir-op-builder -fix) and then fixed cases where temporary OpBuilders were used (as passed in by reference now).
jpienaar
requested review from
Dinistro,
andrewb1999,
blakepelton,
cgyurgyik,
darthscsi,
fabianschuiki,
jiahanxie353,
maerhart,
mortbopet,
rachitnigam,
seldridge and
teqdruid
as code owners
uenoku
approved these changes
Jul 26, 2025
uenoku
left a comment
uenoku
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you for taking care of this migration!
Member
|
Very nice. Thank you for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated post llvm/llvm-project#147168. Basically did
set(CMAKE_CXX_CLANG_TIDY local/clang-tidy -checks=-*,llvm-use-new-mlir-op-builder -fix)
and then fixed O(10) cases where temporary OpBuilders were used as create requires it passed in by reference now.