Skip to content

Enable FP16 on ROCm systems#109

Merged
benson31 merged 9 commits into
llnl:hydrogenfrom
graham63:enable_GPU-fp16_in_HalfPrecision.hpp
Oct 30, 2023
Merged

Enable FP16 on ROCm systems#109
benson31 merged 9 commits into
llnl:hydrogenfrom
graham63:enable_GPU-fp16_in_HalfPrecision.hpp

Conversation

@graham63

Copy link
Copy Markdown

No description provided.

@benson31
benson31 force-pushed the enable_GPU-fp16_in_HalfPrecision.hpp branch from cb2deeb to 2b3a71c Compare October 27, 2023 22:55
@benson31 benson31 changed the title Modified HalfPrecision.hpp to use fp16 on systems with GPUs Enable FP16 on ROCm systems Oct 27, 2023
@benson31
benson31 requested a review from ndryden October 27, 2023 22:57
@benson31

Copy link
Copy Markdown
Collaborator

This has been rebased and now builds successfully.

Comment thread include/hydrogen/utils/HalfPrecision.hpp Outdated

@ndryden ndryden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@benson31
benson31 merged commit 2aa6443 into llnl:hydrogen Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants